feat: Add save config feature within the config subcommand #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Calnex builds a desired config by applying changes to the original config fetched from the device. If anything is updated, it will print the diff. This feature allows users to show the entire config and not only the diff, even if there are no changes to the config. Which might be useful for debugging. It is done by adding a --save <PATH> flag to Calnex's config subcommand. When --save <PATH> is provided, Calnex will dump the config file to <PATH>. Note that --save and --apply is mutually exclusive so either none is provided or one of the two. Reviewed By: leoleovich Differential Revision: D52538805
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52538805 |
|
This pull request has been merged in bbeecec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Calnex builds a desired config by applying changes to the original config fetched from the device. If anything is updated, it will print the diff.
This feature allows users to show the entire config and not only the diff, even if there are no changes to the config. Which might be useful for debugging.
It is done by adding a --save flag to Calnex's config subcommand. When --save is provided, Calnex will dump the config file to . Note that --save and --apply is mutually exclusive so either none is provided or one of the two.
Reviewed By: leoleovich
Differential Revision: D52538805